open-bounty icon indicating copy to clipboard operation
open-bounty copied to clipboard

Claim with "[comment]: " in PR is not shown on bounty issue

Open churik opened this issue 8 years ago • 3 comments

Description

Type: Bug

Summary: if PR contains "[comment]: " in comment - there is no new claim on bounty Example: https://github.com/Chu127001/bounty_1/issues/5 It is referenced with 8 PR, but in SOB only 5 are displayed. sob

Expected behavior

Claim with "[comment]: fixes #issue" is shown

Actual behavior

Claim with "[comment]: fixes #issue" is not shown

Reproduction

  • Create issue with bounty
  • Submit PR with comment "[comment]: Fixes #issue" (it can be "[comment]: resolve #issue" or with other keyword)
  • Check SOB site (Open bounties)
  • Search for issue and check claims

Additional Information

  • Browser: Chrome 62.0.3202.94

  • Operating System: macOs Sierra 10.12.16

With "[]: ", "[some word]: " - issue is not reproducible. I believe it can be related to MarkDown styling ("[comment]: " is one of keywords).

churik avatar Nov 17 '17 15:11 churik

@churik just trying to make sure that I understand you on this one. Generic brackets [] will not cause the issue from showing up, but rather the specific sequence [comment] is the cause of the error?

rcullito avatar Apr 12 '18 22:04 rcullito

@rcullito exactly! It is still reproducible, I rechecked it. And when you merge PR with "[comment]: fixes #issue" issue is closing, so GitHub is handling it as expected.

churik avatar Apr 13 '18 07:04 churik

thanks for clarifying!

rcullito avatar Apr 13 '18 13:04 rcullito