open-bounty
open-bounty copied to clipboard
Multiple users listed as being paid when only one was
User Story
As a bounty payer, I want my payouts screen, and the public Activity feed, to accurately reflect the people I've paid so that I can get an actual sense of my finances and the world knows the truth about who got paid for what.
Description
Type: Bug
Summary: When multiple PRs for the same issue are merged, and one of the claimants is paid out, SOB UI wrongly lists activity stating that multiple people got payouts.
Expected behavior
Only the user who got actually paid with a successful transaction should be listed in the Activity screen as having been paid the bounty.
Actual behavior
Any user who had a merged PR on a bounty will be listed as being paid, even if only one of the users was paid.
Reproduction
- Submit multiple PRs from different users onto a bountied issue
- Merge PRs from multiple users
- Observe on the Activity screen multiple users listed as having "won" the bounty with pending confirmation
- Repo owner goes to Manage Payouts screen and observes multiple possible sign offs
- Repo owner signs off on one of the bounties
- Observe all claims moving to Old Claims section
- On Activity screen observe multiple users being shown as having been paid the bounty
Solution
Only the user who actually received the funds should be listed in the Activity screen as having received them.
Additional info
Here is the issue with the bounty: https://github.com/noman-land/a-milli/issues/17. You can see three merged PRs on it.
Here's the transaction I sent to confirm one: https://ropsten.etherscan.io/tx/0xc9822753fa09dd70bf0cfaf7a328f1e4ccb1408d6f22cbf805ebc33b5acf1ae2
Here is a screenshot of the Activity screen listing both me and hutch as having gotten money, when it was only him:
Here is a screenshot of my Manage Payouts screen. You can see it's not clear which claim was the winning one:
Hang on, if multiple PRs are merged from multiple users, that implies that value was gained from each of those PRs, therefore this more relates to #161 where all participants should be rewarded a % of the bounty.
This may need to be resolved with the #161 enhancement.