Rebase fulu-ebps to unstable, add block error handling, remove incompatible tests
Unit Test Results
9 files 1 401 suites 36m 25s :stopwatch: 5 912 tests 5 351 :heavy_check_mark: 561 :zzz: 0 :x: 23 210 runs 22 528 :heavy_check_mark: 682 :zzz: 0 :x:
Results for commit 13c1fb22.
:recycle: This comment has been updated with latest results.
https://github.com/status-im/nimbus-eth2/actions/runs/15392746027/job/43515161222?pr=7204
Run excluded_files="config.yaml|config.nims|beacon_chain.nimble"
The following files do not have an up-to-date copyright year:
- beacon_chain/el/el_manager
- test_output.log2
- tests/testbcutil.nim
https://github.com/Tomi-3-0/nimbus-eth2/blob/eip7732/beacon_chain/el/el_manager and https://github.com/Tomi-3-0/nimbus-eth2/blob/eip7732/test_output.log2 shouldn't be in the repository to begin with; the copyright date issue is secondary for them.
Run while read -r file; do
Submodule 'vendor/hoodi': '1a603fbe0138fa138d3de61afcae7bb138023179' is not on 'main' as of 2025-05-02 10:53:42 +0000 (branch config: '.gitmodules')
Error: Process completed with exit code 2.
Confuses me slightly, because https://github.com/eth-clients/hoodi/commit/1a603fbe0138fa138d3de61afcae7bb138023179 says it is on main as of 2025-05-02.
the macos-amd64 CI is failing interestingly on https://github.com/status-im/nimbus-eth2/pull/7204/commits/cff3020d2c94965b936691bf36209bd679ab72a6:
2025-06-05T05:18:47.9125230Z Hint: mm: refc; threads: on; opt: speed; options: -d:release
2025-06-05T05:18:47.9169090Z 257106 lines; 161.206s; 2.862GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_signing_node.nim; out: /Users/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/nimbus_signing_node/nimbus_signing_node.json [SuccessX]
2025-06-05T05:18:48.1443900Z scripts/compile_nim_program.sh: line 49: 69128 Segmentation fault: 11 build/generate_makefile "nimcache/release/${BINARY}/${PROJECT_NAME}.json" "nimcache/release/${BINARY}/${BINARY}.makefile"
2025-06-05T05:18:48.1446800Z make: *** [nimbus_signing_node] Error 139
2025-06-05T05:18:48.1448010Z make: *** Waiting for unfinished jobs....
2025-06-05T05:18:53.6903230Z Hint: mm: refc; threads: on; opt: speed; options: -d:release
2025-06-05T05:18:53.6905720Z 235261 lines; 166.980s; 2.96GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/research/block_sim.nim; out: /Users/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/block_sim/block_sim.json [SuccessX]
2025-06-05T05:18:53.8979970Z scripts/compile_nim_program.sh: line 49: 69179 Segmentation fault: 11 build/generate_makefile "nimcache/release/${BINARY}/${PROJECT_NAME}.json" "nimcache/release/${BINARY}/${BINARY}.makefile"
2025-06-05T05:18:53.9043900Z make: *** [block_sim] Error 139
...
2025-06-05T05:19:27.5921720Z Hint: mm: refc; threads: on; opt: speed; options: -d:release
2025-06-05T05:19:27.5924930Z 252644 lines; 200.890s; 3.706GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/tests/consensus_spec/consensus_spec_tests_preset.nim; out: /Users/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/consensus_spec_tests_minimal/consensus_spec_tests_minimal.json [SuccessX]
2025-06-05T05:19:27.8044450Z scripts/compile_nim_program.sh: line 49: 69849 Segmentation fault: 11 build/generate_makefile "nimcache/release/${BINARY}/${PROJECT_NAME}.json" "nimcache/release/${BINARY}/${BINARY}.makefile"
2025-06-05T05:19:27.8054950Z make: *** [consensus_spec_tests_minimal] Error 139
...
2025-06-05T05:19:48.3815590Z Hint: mm: refc; threads: on; opt: speed; options: -d:release
2025-06-05T05:19:48.3818230Z 252644 lines; 221.670s; 4.378GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/tests/consensus_spec/consensus_spec_tests_preset.nim; out: /Users/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/consensus_spec_tests_mainnet/consensus_spec_tests_mainnet.json [SuccessX]
2025-06-05T05:19:48.5969760Z scripts/compile_nim_program.sh: line 49: 70114 Segmentation fault: 11 build/generate_makefile "nimcache/release/${BINARY}/${PROJECT_NAME}.json" "nimcache/release/${BINARY}/${BINARY}.makefile"
2025-06-05T05:19:48.6008990Z make: *** [consensus_spec_tests_mainnet] Error 139
and so is the macs-arm64 CI:
2025-06-05T05:18:48.3093700Z Hint: mm: refc; threads: on; opt: speed; options: -d:release
2025-06-05T05:18:48.3667300Z 257106 lines; 226.700s; 2.862GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/nimbus_signing_node.nim; out: /Users/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/nimbus_signing_node/nimbus_signing_node.json [SuccessX]
2025-06-05T05:18:48.6047470Z scripts/compile_nim_program.sh: line 49: 71158 Segmentation fault: 11 build/generate_makefile "nimcache/release/${BINARY}/${PROJECT_NAME}.json" "nimcache/release/${BINARY}/${BINARY}.makefile"
2025-06-05T05:18:48.6198360Z make: *** [nimbus_signing_node] Error 139
2025-06-05T05:18:48.6401210Z make: *** Waiting for unfinished jobs....
2025-06-05T05:19:01.1147680Z Hint: mm: refc; threads: on; opt: speed; options: -d:release
2025-06-05T05:19:01.1204200Z 235261 lines; 239.488s; 2.96GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/research/block_sim.nim; out: /Users/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/block_sim/block_sim.json [SuccessX]
2025-06-05T05:19:01.3567140Z scripts/compile_nim_program.sh: line 49: 71360 Segmentation fault: 11 build/generate_makefile "nimcache/release/${BINARY}/${PROJECT_NAME}.json" "nimcache/release/${BINARY}/${BINARY}.makefile"
2025-06-05T05:19:01.4137140Z make: *** [block_sim] Error 139
...
2025-06-05T05:20:06.1467270Z Hint: mm: refc; threads: on; opt: speed; options: -d:release
2025-06-05T05:20:06.1471490Z 252644 lines; 304.413s; 3.706GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/tests/consensus_spec/consensus_spec_tests_preset.nim; out: /Users/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/consensus_spec_tests_minimal/consensus_spec_tests_minimal.json [SuccessX]
2025-06-05T05:20:07.0470760Z scripts/compile_nim_program.sh: line 49: 72378 Segmentation fault: 11 build/generate_makefile "nimcache/release/${BINARY}/${PROJECT_NAME}.json" "nimcache/release/${BINARY}/${BINARY}.makefile"
2025-06-05T05:20:07.0553390Z make: *** [consensus_spec_tests_minimal] Error 139
...
2025-06-05T05:20:36.8739980Z Hint: mm: refc; threads: on; opt: speed; options: -d:release
2025-06-05T05:20:36.8743270Z 252644 lines; 335.254s; 4.378GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/tests/consensus_spec/consensus_spec_tests_preset.nim; out: /Users/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/consensus_spec_tests_mainnet/consensus_spec_tests_mainnet.json [SuccessX]
2025-06-05T05:20:37.3489410Z scripts/compile_nim_program.sh: line 49: 72833 Segmentation fault: 11 build/generate_makefile "nimcache/release/${BINARY}/${PROJECT_NAME}.json" "nimcache/release/${BINARY}/${BINARY}.makefile"
2025-06-05T05:20:37.3558920Z make: *** [consensus_spec_tests_mainnet] Error 139
That is, segfaulting during building. It's a bug somewhere, I think in clang, because of a combination of:
- those "2025-06-05T05:20:06.1471490Z 252644 lines; 304.413s; 3.706GiB peakmem; proj: /Users/runner/work/nimbus-eth2/nimbus-eth2/tests/consensus_spec/consensus_spec_tests_preset.nim; ..." lines only occur after
nimper se has finished compiling Nim to C, and; - it's on the two Apple
clang-based platforms, but not the gcc-based Linux platform.
Might be interesting to try using the macos-14 GitHub Actions CI image to see if it fixes this.
https://github.com/status-im/nimbus-eth2/actions/runs/15392746027/job/43515161222?pr=7204
Run excluded_files="config.yaml|config.nims|beacon_chain.nimble" The following files do not have an up-to-date copyright year: - beacon_chain/el/el_manager - test_output.log2 - tests/testbcutil.nimhttps://github.com/Tomi-3-0/nimbus-eth2/blob/eip7732/beacon_chain/el/el_manager and https://github.com/Tomi-3-0/nimbus-eth2/blob/eip7732/test_output.log2 shouldn't be in the repository to begin with; the copyright date issue is secondary for them.
Run while read -r file; do Submodule 'vendor/hoodi': '1a603fbe0138fa138d3de61afcae7bb138023179' is not on 'main' as of 2025-05-02 10:53:42 +0000 (branch config: '.gitmodules') Error: Process completed with exit code 2.Confuses me slightly, because eth-clients/hoodi@1a603fb says it is on
mainas of 2025-05-02.
https://github.com/status-im/nimbus-eth2/actions/runs/15392746027/job/43515161222?pr=7204
Run excluded_files="config.yaml|config.nims|beacon_chain.nimble" The following files do not have an up-to-date copyright year: - beacon_chain/el/el_manager - test_output.log2 - tests/testbcutil.nimhttps://github.com/Tomi-3-0/nimbus-eth2/blob/eip7732/beacon_chain/el/el_manager and https://github.com/Tomi-3-0/nimbus-eth2/blob/eip7732/test_output.log2 shouldn't be in the repository to begin with; the copyright date issue is secondary for them.
Run while read -r file; do Submodule 'vendor/hoodi': '1a603fbe0138fa138d3de61afcae7bb138023179' is not on 'main' as of 2025-05-02 10:53:42 +0000 (branch config: '.gitmodules') Error: Process completed with exit code 2.Confuses me slightly, because eth-clients/hoodi@1a603fb says it is on
mainas of 2025-05-02.
Thanks. I will clean this up, was an oversight.
Probably a timing/caching issue with the submodule; i will try updating the submodule reference
@tersec The macOS CI failure appears to be related to network/async operations in the queryValidatorsSource() test. My proposed fix is adding macOS-specific timeouts to the network test. Do you think this is a good approach?
Reasonable, yes