nimbus-eth2 icon indicating copy to clipboard operation
nimbus-eth2 copied to clipboard

testing c-kzg-4844 `v2.0.0`

Open agnxsh opened this issue 6 months ago • 1 comments

This pr has another fork of nim-kzg4844, for now, this is to essentially CI test, the new simpler bindings for c-kzg-4844 introduced by @jtraglia

In addition to that also the newest release of c-kzg-4844 v2.0.0, which for the first time include peerDAS functions in it, this PR would eventually allow us to merge peerDAS crypto and it's other core specs into unstable

ref PR: https://github.com/ethereum/c-kzg-4844/pull/482

Gist of changes, as per Justin:

- Remove the "zero overhead aliases" which I find pretty confusing.
- I think one could argue that these are over-complicated & prone to issues.
- When adding EIP-7594 support, I made several mistakes.
- Remove duplicate tests, only use reference tests.
- The tests for each API (kzg, kzg_abi, kzg_ex) were too much.
- It's okay to only run through the reference tests.
- Use a global KzgCtx like the other bindings do.
- This is simpler & also less prone to mistakes.
- Requires that free_trusted_setup is called on exit.

All the necessary fixes in nimbus-eth2 are made by me in this PR.

agnxsh avatar Aug 21 '24 08:08 agnxsh