nimbus-eth2 icon indicating copy to clipboard operation
nimbus-eth2 copied to clipboard

various REST serialization cleanups

Open etan-status opened this issue 3 years ago • 1 comments

  • delete unused version constants
  • move EpochParticipationFlags serialization to other serializers
  • move JustificationBits serialization after base types
  • add eth-consensus-version for JSON in uniform way
  • add sszResponsePlain for pre-encoded SSZ data
  • use withState in jsonResponseState
  • add missing section comments
  • use GraffitiBytes.init reader instead of hexToByteArray
  • rm unused Version/ForkDigest/DomainType/GraffitiBytes reader
  • rm unused dump function for KeystoresAndSlashingProtection
  • extend REST test with checks for Eth-Consensus-Version

etan-status avatar Sep 19 '22 15:09 etan-status

Unit Test Results

       9 files  +       6     660 suites  +440   19m 43s :stopwatch: + 13m 31s 1 982 tests +   148  1 835 :heavy_check_mark: +     20  147 :zzz: +128  0 :x: ±0  8 060 runs  +5 372  7 889 :heavy_check_mark: +5 220  171 :zzz: +152  0 :x: ±0 

Results for commit fb618501. ± Comparison against base commit 23007eac.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 19 '22 23:09 github-actions[bot]

Better to split this one into multiple PRs.

etan-status avatar Sep 23 '22 09:09 etan-status