nimbus-eth2 icon indicating copy to clipboard operation
nimbus-eth2 copied to clipboard

Post merge polish

Open mratsim opened this issue 2 years ago • 5 comments

Some post-merge polish after looking at some log files:

  • Say that we are connected to an Execution Client (not just Engine API which is a technical term users don't care about)
  • Use Execution/Consensus instead of eth1 / eth2 in user logs (not done for debug)

One thing that was recurring as well is the people not updating --web3-url=http://localhost:8545 to --web3-url=http://localhost:8551 (or websocket).

I think we need to add a log whether we are connected as a mere web3 (to monitor deposits), or as a fully-fledged CL. Though now that mainnet is switch to PoS, maybe there is no interest at all in pre-PoS with deposit monitoring as all chains of interest have moved to PoS? Or use a different consensus algorithms already integrated within an EL (for rollups for example).

Notably missing: do we send a stub to the ELs on mainnet or do we like today send the actual expected values?

mratsim avatar Sep 16 '22 08:09 mratsim

TODO overlap with #4126 @arnetheduck

mratsim avatar Sep 16 '22 08:09 mratsim

In general, are "execution layer" and "execution client" treated as proper nouns by the spec? I agree with using that rather than engine API, but I'm not sure about the capitalization here.

tersec avatar Sep 16 '22 09:09 tersec

If I were changing the strings, I'd probably hint about engine configuration somewhere at least, given that in executions clients one has to enable the engine api specifically

arnetheduck avatar Sep 16 '22 09:09 arnetheduck

#4126 needs to go in before this one though - until then, we're simply not sending the right messages at the right time and whatever we print here will not be right

arnetheduck avatar Sep 16 '22 09:09 arnetheduck

Unit Test Results

       12 files       860 suites   1h 7m 32s :stopwatch:   1 982 tests   1 835 :heavy_check_mark: 147 :zzz: 0 :x: 10 662 runs  10 472 :heavy_check_mark: 190 :zzz: 0 :x:

Results for commit 30d48ee0.

github-actions[bot] avatar Sep 16 '22 12:09 github-actions[bot]

these changes have been, or are being, incorporated in various other PR:s, closing for now

arnetheduck avatar Mar 02 '23 16:03 arnetheduck