nimbus-eth2
nimbus-eth2 copied to clipboard
log NimVersion
After this PR:
NOT 2022-08-03 19:22:16.939+02:00 Starting beacon node topics="beacnde" version=v22.7.0-52b32c-stateofus nimVersion=1.2.16 enr=(...)
IMO, the commit hash for Nim is not needed if we stick to the released stable versions of the compiler. (e.g. 1.2.16 or 1.6.8)
Unit Test Results
12 files ±0 860 suites ±0 1h 6m 48s :stopwatch: - 7m 39s 1 911 tests ±0 1 764 :heavy_check_mark: ±0 147 :zzz: ±0 0 :x: ±0 10 341 runs ±0 10 151 :heavy_check_mark: ±0 190 :zzz: ±0 0 :x: ±0
Results for commit 607bdf3a. ± Comparison against base commit 52b32c13.
I do not like idea to put nimVersion
in Starting beacon node
log line.
Also i do not like idea to keep only nimVersion
because even right now specific nim version commit hash do not equal to nim version commit hash which is distributed and maintained by nimbus-build-system
.
the commit hash for Nim is not needed if we stick to the released stable versions of the compiler. (e.g. 1.2.16 or 1.6.8)
We might still need Nim specific commits in the future, especially as people try early for compat with 1.7/1.8 or before Nim 2.0