VC: keeps spamming BN on failure

[arnetheduck]

When the BN is unable to publish an attestation (for example because it has no peers on the topic), VC starts a tight spam loop, reposting the same attestation over and over again - it seems like it never stops until it finally succeeds - below is an example of such an attestation - the same thing happens with aggregates.

If a BN fails to process an attestation, the VC should retry another BN perhaps, but not keep sending the message to the same BN.

Below is an example (with a new log message):

00000000000000000000000000000000000000000000000, data: (slot: 3338476, index: 43, beacon_block_root: \"33e1201b\", source: \"104326:b5382e88\", target: \"104327:01d74b6f\"), signature: \"844e51a3\")" error="No peers on libp2p topic"
NOT 2022-06-30 08:15:20.120+02:00 No peers for topic, skipping publish       topics="libp2p gossipsub" peersOnTopic=0 connectedPeers=0 topic=/eth2/82f4a72b/beacon_attestation_43/ssz_snappy
NOT 2022-06-30 08:15:20.120+02:00 Produced attestation not sent              attestation="(aggregation_bits: 0b00000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000, data: (slot: 3338476, index: 43, beacon_block_root: \"33e1201b\", source: \"104326:b5382e88\", target: \"104327:01d74b6f\"), signature: \"844e51a3\")" error="No peers on libp2p topic"
NOT 2022-06-30 08:15:20.163+02:00 No peers for topic, skipping publish       topics="libp2p gossipsub" peersOnTopic=0 connectedPeers=0 topic=/eth2/82f4a72b/beacon_attestation_43/ssz_snappy
NOT 2022-06-30 08:15:20.163+02:00 Produced attestation not sent              attestation="(aggregation_bits: 0b00000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000, data: (slot: 3338476, index: 43, beacon_block_root: \"33e1201b\", source: \"104326:b5382e88\", target: \"104327:01d74b6f\"), signature: \"844e51a3\")" error="No peers on libp2p topic"
NOT 2022-06-30 08:15:20.164+02:00 No peers for topic, skipping publish       topics="libp2p gossipsub" peersOnTopic=0 connectedPeers=0 topic=/eth2/82f4a72b/beacon_attestation_43/ssz_snappy
NOT 2022-06-30 08:15:20.164+02:00 Produced attestation not sent              attestation="(aggregation_bits: 0b00000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000, data: (slot: 3338476, index: 43, beacon_block_root: \"33e1201b\", source: \"104326:b5382e88\", target: \"104327:01d74b6f\"), signature: \"844e51a3\")" error="No peers on libp2p topic"
NOT 2022-06-30 08:15:20.165+02:00 No peers for topic, skipping publish       topics="libp2p gossipsub" peersOnTopic=0 connectedPeers=0 topic=/eth2/82f4a72b/beacon_attestation_43/ssz_snappy
NOT 2022-06-30 08:15:20.165+02:00 Produced attestation not sent              attestation="(aggregation_bits: 0b00000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000, data: (slot: 3338476, index: 43, beacon_block_root: \"33e1201b\", source: \"104326:b5382e88\", target: \"104327:01d74b6f\"), signature: \"844e51a3\")" error="No peers on libp2p topic"
NOT 2022-06-30 08:15:20.206+02:00 No peers for topic, skipping publish       topics="libp2p gossipsub" peersOnTopic=0 connectedPeers=0 topic=/eth2/82f4a72b/beacon_attestation_43/ssz_snappy
NOT 2022-06-30 08:15:20.206+02:00 Produced attestation not sent              attestation="(aggregation_bits: 0b000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

[cheatfate]

And what scenario should be used when only one beacon_node is used and no other beacon_node is available?