nimbus-eth1 icon indicating copy to clipboard operation
nimbus-eth1 copied to clipboard

hive: devp2p/eth: implement missing handler of eth protocol

Open jangko opened this issue 3 years ago • 2 comments

many of the handlers of eth protocol both in nim-eth and nimbus-eth1 are still empty or maybe buggy. we need to implement them to pass devp2p/eth tests in hive

jangko avatar May 20 '21 09:05 jangko

Can you expand on this a bit? Which parts of the eth protocol does Hive exercise, and which versions?

jlokier avatar Jul 01 '21 22:07 jlokier

hive will relay the test to https://github.com/ethereum/go-ethereum/tree/master/cmd/devp2p/internal/ethtest

from brief glance it looks like ethtest try to connect using eth/66 first then fallback to eth/65 or eth/64.

some of protocol methods used by ethtest are:

  • Status
  • GetBlockHeaders
  • NewBlock
  • NewBlockHashes
  • NewPooledTransactionHashes?
  • GetBlockBodies
  • GetPooledTransactions
  • Transactions

not tested methods:

  • GetNodeData
  • GetReceipts

jangko avatar Jul 02 '21 01:07 jangko