nim-snappy icon indicating copy to clipboard operation
nim-snappy copied to clipboard

require Nim 2.0

Open tersec opened this issue 1 year ago • 4 comments

tersec avatar Jun 24 '24 22:06 tersec

ditto..

arnetheduck avatar Jun 25 '24 04:06 arnetheduck

https://github.com/status-im/status-desktop/tree/master/vendor doesn't use this repo.

tersec avatar Jun 25 '24 05:06 tersec

nevertheless, since there's no concrete reason to drop 1.6 (ie a specific bug or feature), it's better to keep the option open since we're aiming to integrate more of Nimbus into there and elsewhere, also in community projects.

Snappy in particular sees very little maintenance / changes it's quite stable as-is.

One of its selling points is the ease of integrating it into projects which would be limited by a narrow nim version support requirement. If we need to make an overhaul, that would be a good time to drop support as well.

arnetheduck avatar Jun 25 '24 05:06 arnetheduck

Here is a less controversial version of these changes: https://github.com/status-im/nim-snappy/pull/30

narimiran avatar Jun 25 '24 15:06 narimiran

With #30 merged, it is ok to close this one.

narimiran avatar Oct 23 '24 18:10 narimiran