nim-chronos icon indicating copy to clipboard operation
nim-chronos copied to clipboard

Fix a build issue affecting nim-eth/rlpx.nim

Open zah opened this issue 5 years ago • 1 comments

zah avatar Apr 10 '19 00:04 zah

I have no idea what this does - but it looks like the kind of issue that would be valuable to start building up a test base around - even to serve as example of intended behavior

arnetheduck avatar Apr 10 '19 01:04 arnetheduck

@zah is this still relevant?

arnetheduck avatar Nov 01 '22 12:11 arnetheduck

This is a good change in general, but not strictly needed right now. @cheatfate asked me once about a strange build problem he was seeing and this fix was addressing it.

zah avatar Nov 01 '22 20:11 zah

so rebase and merge? ie if it's at least harmless and sometimes helps?

arnetheduck avatar Nov 02 '22 06:11 arnetheduck

closing this since it's stale and conflicts with other PR:s - we can revisit if it becomes relevant again

arnetheduck avatar May 23 '23 12:05 arnetheduck