statping icon indicating copy to clipboard operation
statping copied to clipboard

Duplicate Service URLs are possible

Open d-Rickyy-b opened this issue 3 years ago • 24 comments

Describe the bug

It is possible to create two (or more) services that have the exact same service url. There should be a check so that service URLs are not duplicated.

To Reproduce

Steps to reproduce the behavior:

  1. Use version v0.90.74 (Docker)
  2. Open the admin dashboard
  3. Create a new service - call it "test" (Service Name). It will auto fill the Permalink URL field with "test"
  4. Save and go back to create another service
  5. Call it "test" again, it will also have "test" as Permalink URL autofilled
  6. Open the regular status page (https://host.tld/) and try to open both services individually

Expected Behavior

There shouldn't be a way to assign the same service url for two services.

  1. I'd expect the application to throw an error and tell me to use another service url because the other one is already in use. Service URLs should be unique so that we can visit both services individually.

  2. I'd also expect the UI to automatically append something like -1 to the Service URL field automatically during the creation process if the URL is already taken. Or a combination of name & group names. But that's of course just a convenience feature.

Actual Behavior

I can add as many services with the exact same service URL as I want. This becomes an issue if you have several services with the same name but in different groups (e.g. one URL for the "API" group, one for the group "website"). Both check different services. But if we didn't manually change the Permalink URL, we can only view one of both services


Workaround

You can work around this issue by manually setting a custom Permalink URL for your service.

Impact

This could lead to confusion (Both services - although different - show exactly the same data). This could also lead to feeling of a false certainty (no issues displayed although service offline).


Screenshots

I used two different domains "example.com" and "example1.com". grafik

grafik

grafik

If you have any questions regarding this issue, feel free to ask.

Slack GitHub release Build Status

d-Rickyy-b avatar Jun 04 '21 00:06 d-Rickyy-b

But you might be testing different things on the same endpoint URL such as an API that accepts different POST requests.

adamboutcher avatar Jul 01 '21 11:07 adamboutcher

But you might be testing different things on the same endpoint URL such as an API that accepts different POST requests.

Thanks for your comment. As I noted in my initial comment: But if we didn't manually change the Permalink URL, we can only view one of both services

So there is no way for us to manipulate a 'service' again without renaming one. Because both service sites are reached through the same URL /<service_name>.

d-Rickyy-b avatar Jul 01 '21 17:07 d-Rickyy-b

Ah, you mean that you can give the same service name, I thought you meant the end-point URLs...

Yes maybe having a duplicate check on the Service Name would be useful.

adamboutcher avatar Jul 02 '21 13:07 adamboutcher

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Aug 17 '21 00:08 github-actions[bot]

This issue is still relevant

d-Rickyy-b avatar Aug 20 '21 09:08 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Oct 05 '21 00:10 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar Oct 05 '21 18:10 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Nov 21 '21 00:11 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar Nov 21 '21 01:11 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Jan 06 '22 00:01 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar Jan 07 '22 11:01 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Feb 22 '22 00:02 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar Feb 22 '22 01:02 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Apr 09 '22 01:04 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar Apr 10 '22 21:04 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar May 26 '22 01:05 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar May 26 '22 20:05 d-Rickyy-b

This is some serious dedication to keeping the issue from being stale for a year!

For what it’s worth, you’ll likely have more traction on one of the main/active forks of this repo at: https://github.com/statping-ng/statping-ng

codybennett avatar Jun 05 '22 08:06 codybennett

This is some serious dedication to keeping the issue from being stale for a year!

For what it’s worth, you’ll likely have more traction on one of the main/active forks of this repo at: https://github.com/statping-ng/statping-ng

Thank you, I know about statping-ng. Actually, I am no longer interested in using statping altogether. There are way better alternatives out there. I'm mainly keeping this issue alive for others to see that this project is abandoned.

d-Rickyy-b avatar Jun 08 '22 09:06 d-Rickyy-b

hi Rickyy. Could you inform some alternatives to use them Statping-NG?

dnsk8dn avatar Jun 21 '22 02:06 dnsk8dn

Hi @dnsk8dn I am using https://github.com/louislam/uptime-kuma for a while now and it works like a charm and has a very active community.

d-Rickyy-b avatar Jun 21 '22 18:06 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Aug 06 '22 01:08 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar Aug 07 '22 01:08 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Sep 22 '22 01:09 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar Sep 28 '22 08:09 d-Rickyy-b

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.

github-actions[bot] avatar Nov 14 '22 01:11 github-actions[bot]

It's still relevant!

d-Rickyy-b avatar Nov 14 '22 01:11 d-Rickyy-b

Actually, I really don't care getting this fixed anyway, because I am using uptime-kuma, so I'll just close it on my own.

d-Rickyy-b avatar Dec 05 '22 20:12 d-Rickyy-b