Minimac4 icon indicating copy to clipboard operation
Minimac4 copied to clipboard

Move temp file writing outside of parallel loop

Open jonathonl opened this issue 6 years ago • 1 comments

https://github.com/statgen/Minimac4/blob/5fa7d654d95453b353b26ecbe56637b655f4e3bb/src/Imputation.cpp#L686-L704

It would be much cleaner to move this entire block outside of the OMP for loop. Adding counter_sample_imputation_finished is an unnecessary complication that makes the code less friendly to read.

jonathonl avatar Sep 14 '18 13:09 jonathonl

No no hold on that. I am not sure what exactly you are suggesting but let's once talk about it. I am just leaving for work.

On Fri, Sep 14, 2018, 6:48 AM Jonathon LeFaive [email protected] wrote:

https://github.com/statgen/Minimac4/blob/5fa7d654d95453b353b26ecbe56637b655f4e3bb/src/Imputation.cpp#L686-L704

It would be much cleaner to move this entire block outside of the OMP for loop. Adding counter_sample_imputation_finished is an unnecessary complication that makes the code less friendly to read.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/statgen/Minimac4/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AHuICFJithZxbsENr-uTS13oG-Aif3_vks5ua7OigaJpZM4WpTj0 .

Santy-8128 avatar Sep 14 '18 15:09 Santy-8128