xstate
xstate copied to clipboard
xstate-svelte: Avoid using svelte store get in useSelector.
The Svelte docs say get should not be used in hot paths. It is used in useSelector to compare the updated value with the previous value. This PR changes the function to store the previous value in a local variable instead.
🦋 Changeset detected
Latest commit: ccfb431d177f3bb9e076f7a1b09d4c7d1e607087
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @xstate/svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
👇 Click on the image for a new way to code review
-
Make big changes easier — review code in small groups of related files
-
Know where to start — see the whole change at a glance
-
Take a code tour — explore the change with an interactive tour
-
Make comments and review — all fully sync’ed with github
Legend

This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit ccfb431d177f3bb9e076f7a1b09d4c7d1e607087:
| Sandbox | Source |
|---|---|
| XState Example Template | Configuration |
| XState React Template | Configuration |
Is this good to go?
Is this good to go?
I assume the question wasn't directed at me, but as far as I'm concerned this is releasable. We've been using this version in production for a month or so without any issues, would be nice to not have to maintain a separate version.