xstate icon indicating copy to clipboard operation
xstate copied to clipboard

Added failing test for self-events

Open mattpocock opened this issue 3 years ago • 8 comments

Here, the self event should be called while in another path - it shouldn't require its own path in order to be run.

mattpocock avatar May 31 '22 13:05 mattpocock

⚠️ No Changeset found

Latest commit: 70d9f5a14b6ef49f6738f2512e9182c2f000763b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 31 '22 13:05 changeset-bot[bot]

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar May 31 '22 13:05 ghost

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 70d9f5a14b6ef49f6738f2512e9182c2f000763b:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

codesandbox-ci[bot] avatar May 31 '22 13:05 codesandbox-ci[bot]

Does it matter though? Isn't this a similar problem to the one reported here? I mean, we've ensured here that all transitions were actually taken.

Andarist avatar May 31 '22 15:05 Andarist

Similar, but this one seems easier to resolve.

mattpocock avatar May 31 '22 17:05 mattpocock

@davidkpiano this PR now contains some commits that shouldn't quite be here - at least not displaying as something that has changed here. This makes navigating & reviewing a PR like this much harder. Could we clean this up somehow? I think this is mainly related to merge commits that are not on the main branch.

I think there is a good chance that you might fix this branch with:

git checkout matt/added-failing-test-for-self-events && git reset --hard f78b268546ad4ad68a2bbf465d3dfaaf9e6ff086 && git merge --no-ff main && git push --force

Note that after the merge step you might need to resolve conflicts.

Andarist avatar May 31 '22 21:05 Andarist

@Andarist I fixed it 🔧

davidkpiano avatar May 31 '22 21:05 davidkpiano

Thanks ❤️

Andarist avatar May 31 '22 22:05 Andarist