xstate icon indicating copy to clipboard operation
xstate copied to clipboard

[core] Add failing test for general `model.assign(...)` actions

Open davidkpiano opened this issue 4 years ago • 3 comments

This PR demonstrates the failure for transitions to accept general model.assign(...) functions with the following characteristics:

  1. Are defined outside of the machine definition
  2. Can accept any event

Potentially addressed by https://github.com/statelyai/xstate/pull/2690

davidkpiano avatar Nov 30 '21 01:11 davidkpiano

⚠️ No Changeset found

Latest commit: 1eb61393ffe5b79915ef98eb90672596a6ac849f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 30 '21 01:11 changeset-bot[bot]

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

ghost avatar Nov 30 '21 01:11 ghost

Should this be tackled in v5 instead, where we have better typings for actions?

davidkpiano avatar Dec 21 '21 15:12 davidkpiano

Since we phased out createModel API this is no longer needed and types are being reworked on anyway.

Andarist avatar Jun 15 '23 13:06 Andarist