xstate-viz icon indicating copy to clipboard operation
xstate-viz copied to clipboard

Andarist/webext groundwork refactor

Open Andarist opened this issue 3 years ago • 2 comments
trafficstars

Goals of this PR:

  • make the "layout" of the main app more customizable, or rather - achieve bigger control over the pieces that are rendered without a lot of conditional rendering tightly couple to context etc
  • this allows us to render (in the future) <WebExtension/> that eg. doesn't depend on Monocao anyhow or doesn't know anything about embed mode etc
  • remove dependency on SCSS to make it easier to bundle <WebExtension/> and also to migrate closer to a single source of truth for styling (previously we were mixing SCSS with Chakra)

In general, to review this PR it might be the easiest to just follow its commits. Most are self-contained refactoring pieces, with some minor bug fixes at the end.

I'm not super fond of some of those "customizable" points here - perhaps this could be structured in a better way. I feel though that the current shape of the code is manageable and we could always refactor stuff later. If you have any general thoughts on composition patterns for problems like this - I'm happy to discuss different tradeoffs etc.

Andarist avatar Jun 21 '22 13:06 Andarist

⚠️ No Changeset found

Latest commit: 5bdf243602f0cd47f33362f0b3ba836d7ae0817b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 21 '22 13:06 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
xstate-viz ✅ Ready (Inspect) Visit Preview Jun 21, 2022 at 1:48PM (UTC)

vercel[bot] avatar Jun 21 '22 13:06 vercel[bot]