xstate-viz icon indicating copy to clipboard operation
xstate-viz copied to clipboard

Fix a few bugs related to custom events

Open farskid opened this issue 2 years ago • 5 comments

Fixes https://github.com/statelyai/xstate-viz/issues/250 https://github.com/statelyai/xstate-viz/issues/222 https://github.com/statelyai/xstate-viz/issues/223

farskid avatar Sep 08 '21 16:09 farskid

⚠️ No Changeset found

Latest commit: 7cc57c836c111eb1695a76b02de8f3d689cf59a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 08 '21 16:09 changeset-bot[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/statelyai/xstate-viz/2HPnRDiAuwNmdUQbSUgBrTxZa1YC
✅ Preview: https://xstate-viz-git-farskid-sta-578-send-button-is-0c3dfd-statelyai.vercel.app

vercel[bot] avatar Sep 08 '21 16:09 vercel[bot]

Could we also add some basic tests for this thing?

It would also be nice if we could explain such changes, at least briefly. What has been previously assumed? What has happened? How it got fixed? And why the new approach is better? I had to figure this stuff out on my own when reviewing this - and having some kind of an explanation/reasoning behind the changes would help me a lot.

I'm on it.

farskid avatar Sep 09 '21 10:09 farskid

@farskid @Andarist Besides tests, what are the remaining changes here?

davidkpiano avatar Sep 16 '21 13:09 davidkpiano