xstate-tools icon indicating copy to clipboard operation
xstate-tools copied to clipboard

add `stateValues` to typegen output

Open brunocrosier opened this issue 3 years ago • 4 comments

  • Fix issue where generated .typegen.ts files in __examples__ folder would not be deleted
  • Add stateValues to typegen output, so that it can be used in https://github.com/statelyai/xstate/pull/3342

brunocrosier avatar Jun 08 '22 21:06 brunocrosier

⚠️ No Changeset found

Latest commit: f8420228cf9f3226704b162d6d8bb39391d6e30f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 08 '22 21:06 changeset-bot[bot]

I know that it has been a while since you have created this PR - but could you rebase this on top of the main branch and add snapshots tests for the getTypegenOutput (the test setup has been refactored in the meantime)? I'd like to see how the generated output looks like to decide if we should include this as part of the typegen types or not.

Andarist avatar Aug 18 '22 21:08 Andarist

I know that it has been a while since you have created this PR - but could you rebase this on top of the main branch and add snapshots tests for the getTypegenOutput (the test setup has been refactored in the meantime)? I'd like to see how the generated output looks like to decide if we should include this as part of the typegen types or not.

Sorry I lost a bit of context on this since opening the PR but I hope these are the changes you requested 🙂

brunocrosier avatar Aug 20 '22 00:08 brunocrosier

Yeah, this is what I had in mind - thank you 🙏 I'm gonna try to take a look at this soon

Andarist avatar Aug 20 '22 08:08 Andarist