vscode-runme icon indicating copy to clipboard operation
vscode-runme copied to clipboard

Open/Close Terminal Cell Button

Open christian-bromann opened this issue 3 years ago • 4 comments

Currently users have the ability to open the terminal if they were running interactive cells, e.g.:

Screenshot 2022-11-16 at 11 32 22

To complete the experience it would be great if we could change the button to say "Close Terminal". Unfortunately VS Code doesn't re-render that section quite often so there is no way for use to do that atm.

christian-bromann avatar Nov 16 '22 19:11 christian-bromann

I'll give this a shot

lorenzejay avatar Nov 17 '22 17:11 lorenzejay

I'll give this a shot

Feel free, it would be great to better understand when VS Code re-renders these provider. I initially tried to tackle this myself and gave up as I believe it is currently not possible.

christian-bromann avatar Nov 17 '22 18:11 christian-bromann

@christian-bromann have you tried this ? Screenshot 2022-11-22 at 10 46 03 AM

would recall provideCellStatusBarItems and can use an if statement to show open/close right?

lorenzejay avatar Nov 22 '22 18:11 lorenzejay

@christian-bromann have you tried this ? Screenshot 2022-11-22 at 10 46 03 AM

would recall provideCellStatusBarItems and can use an if statement to show open/close right?

nvm... this doesnt work as the provider is not calling the command which won't tell if there was any event

lorenzejay avatar Nov 22 '22 18:11 lorenzejay

I was able to get some partial progress on this problem! In particular, I was able to accomplish re-rendering using onDidChangeCellStatusBarItems. This allows for the following:

Unfortunately, there is no way (as far as I know) to determine if the bottom panel is open, so the best you can do is tell if the relevant terminal is "active." Still, this provides a solution to #124 (see #125), and could be of use for other future features.

mxsdev avatar Jan 15 '23 23:01 mxsdev

@sourishkrout I think we can close this issue as we don't have the button anymore. The way the UX suggests running task within the CLI doesn't raise a need for this functionality.

christian-bromann avatar Aug 22 '23 18:08 christian-bromann

Agreed.

sourishkrout avatar Aug 22 '23 19:08 sourishkrout