vscode-runme icon indicating copy to clipboard operation
vscode-runme copied to clipboard

Connect to `127.0.0.1` instead of `localhost`

Open mxsdev opened this issue 2 years ago • 3 comments

Would be nice to connect directly to 127.0.0.1 and use this as the server address, rather than localhost, since localhost is technically not guaranteed to exist. This has already caused issues for a user in #447

Trying to do this right now results in the following console message:

image

Functionality still works though.

mxsdev avatar Apr 26 '23 20:04 mxsdev

Perhaps we can attempt connecting to localhost for several successive tries before switching to 127.0.0.1 to circumvent this ugly warning until Electron moves to node 18. Wdyt @mxsdev?

sourishkrout avatar Apr 27 '23 21:04 sourishkrout

@sourishkrout

Yeah, that could work.

To be honest I'd personally rather just eat the warning or keep it as localhost than do that. Because it has to work nicely with our existing retry mechanism and that introduces some minor headaches...But I'm fine with doing that if you really want

to circumvent this ugly warning until Electron moves to node 18.

Are we blocked on upgrading grpc-node because of this? (If so I didn't know that)

mxsdev avatar Apr 27 '23 21:04 mxsdev

Not a priority. Let's keep this in the backlog for now.

to circumvent this ugly warning until Electron moves to node 18.

Are we blocked on upgrading grpc-node because of this? (If so I didn't know that)

I thought the error came out of opensll linked with node 16 but could also be grpc-node 🤷.

sourishkrout avatar Apr 28 '23 12:04 sourishkrout