vscode-runme icon indicating copy to clipboard operation
vscode-runme copied to clipboard

bug: missing input for environment type github action

Open qweasd1 opened this issue 10 months ago • 4 comments

Hi, first, runme is a really nice young tool. Just want to report a bug when I run it inside vscode for github action. for one of my github action, I have one input as "environment" type.

workflow_dispatch:
    inputs:
      environment:
        description: 'Environment to run Deployment'
        type: environment
        required: true
        default: stage
      synthetic_test_status:
        description: 'Status of Datadog Synthetic test'
        type: choice
        default: live
        options:
          - live
          - paused
 ...

however, it can't shown in vs code plugin image

So seems this is bug in vs code plugin.

qweasd1 avatar Apr 17 '24 20:04 qweasd1

Hi @qweasd1! Thanks for reporting this issue. We'll take a look and let you know if we have any questions.

sourishkrout avatar Apr 17 '24 20:04 sourishkrout

@sourishkrout thanks! I also test some other input type like "boolean", it can't shown. Seems only "string" input are shown. Not sure whether this is a incomplete feature.

qweasd1 avatar Apr 17 '24 20:04 qweasd1

Good to know! We'll check into the non-string types, too.

sourishkrout avatar Apr 17 '24 23:04 sourishkrout

here is the source code I think https://github.com/stateful/vscode-runme/blob/f5aa15b5e1765a2420110659ee4d1da8b245d773/src/client/components/github/workflowViewer.ts#L175 I think we just don’t include other types and also don’t know why limit choice options to 3

qweasd1 avatar Apr 17 '24 23:04 qweasd1

Hi @qweasd1 👋🏽
First, thank you for reporting this issue, it's helping us to get each day better. I'm glad to share that the latest version of the extension now supports Environments and all the missing types for the GitHub Action manual dispatch renderer, read more in our Changelog.

Please take a look and let us know if you are able to successfully use your GitHub Action! 💪🏽

degrammer avatar May 03 '24 20:05 degrammer

Thanks and nice work! Will check and leave feedback!

qweasd1 avatar May 03 '24 20:05 qweasd1

work as expected!

qweasd1 avatar May 04 '24 00:05 qweasd1