runme icon indicating copy to clipboard operation
runme copied to clipboard

Long Pauses Rendering Notebooks On Initial Load with Code-Server

Open jlewi opened this issue 1 year ago • 6 comments
trafficstars

I started noticing that when I would try to open a notebook it would take a really long time to render or might not render at all. I'll have a couple notebooks open and then try to open a new notebook and it will take a long time (10s of seconds -minutes) to render.

I'm running runme in code-server and then accessing it in the browser. So it could be particular to that setup. I haven't tried to see if this problem occurs in other settings.

It seemed to be working fine for most of the day and then this problem started occurring.

I can open the file in the markdown editor just fine. So my suspicion is it has something to do with serialization. The next time I observe this I'll try clearing the app data in the browser and seeing what happens.

I've tried reloading the window and that doesn't seem to help.

jlewi avatar Aug 09 '24 16:08 jlewi

Would you mind adding a video clip @jlewi? I just tried it myself, and it opened instantly.

The very first open (and every 30d) might take a few seconds longer (entropy for pk) because Runme is rotating its CA. Sounds like that is not it in your case.

sourishkrout avatar Aug 09 '24 16:08 sourishkrout

Will do. FWIW, I recognize this is an unhelpful bug report and don't know how to reproduce it. I think its reasonable to close it as unactionable. I mainly wanted to start a record where I could start to log information.

jlewi avatar Aug 09 '24 21:08 jlewi

Here's a video; I had to record with GVC so its not as nice as with screen recorder.

Here's what the video is showing

  • I just opened a brand new notebook build_tensorrt.md and its "spinning" trying to load it
  • I try to click on the buttons to add a code cell or markdown cell and nothing happens
  • I click on the M window and instead of seeing the markdown for the new notebook I get a different file
  • I then right click and say open in text editor for build_Tensorrt.md
  • Interestingly, the raw markdown shows a bunch of code cells
    • Presumably these are the result of click on the add code cell button; but they aren't rendering.

https://github.com/user-attachments/assets/10727bf6-d74b-453c-9082-3620e188758c

jlewi avatar Aug 10 '24 17:08 jlewi

Here's another example.

  • When the video starts I have an open file build_tensorrtllm.md which isn't rendering
  • I click on M and it doesn't show up
  • I then close it and reopen it and it doesn't render
  • When I look at the RunMe logs we see a bug from the GrpcProgramRunner about not being to write to a closed program session
  • I reset the session and try again and it seems to render.

https://github.com/user-attachments/assets/3100426f-2787-4d0d-8e95-5383069fec90

jlewi avatar Aug 11 '24 02:08 jlewi

Are there any suspicious-looking logs in Output->Runme (bottom panel)? My guess is that they're related to task discovery, where we traverse the repo's tree for markdown files.

Perhaps related to this https://github.com/stateful/runme/pull/646.

sourishkrout avatar Aug 12 '24 14:08 sourishkrout

I just remember that I've seen issue like this on Remote Workspace when I have a local runme binary set in my extension settings, such as:

"runme.server.binaryPath": "/Users/sourishkrout/Projects/stateful/oss/runme/runme"

sourishkrout avatar Aug 12 '24 20:08 sourishkrout