cms icon indicating copy to clipboard operation
cms copied to clipboard

[5.x] Ensure `minimum-stability` is `dev` before requiring new addon

Open duncanmcclean opened this issue 1 year ago • 4 comments

This pull request fixes an issue with the php please make:addon command where Composer will throw an error when requiring a new addon when an app's minimum-stability setting is anything other than dev.

duncanmcclean avatar Sep 18 '24 14:09 duncanmcclean

Ideally we should avoid that.

If you don't have mininum-stability, you're still able to do composer require my/addon dev-master and it'll work.

It's just a matter of figuring out what branch it needs. dev-master or dev-main. Composer figures it out under the hood somehow. Maybe we can lift the logic from there. 🤔

jasonvarga avatar Sep 18 '24 18:09 jasonvarga

Going to mark this as a draft for now, until I have time to dig into this some more.

duncanmcclean avatar Sep 23 '24 09:09 duncanmcclean

I think this does it. Wanna check?

jasonvarga avatar Sep 26 '24 21:09 jasonvarga

Yep, that does it! Thanks for taking a look.

duncanmcclean avatar Sep 27 '24 10:09 duncanmcclean