innerself icon indicating copy to clipboard operation
innerself copied to clipboard
verified publisher icon stasm

WIP Selectors

Open stasm opened this issue 8 years ago • 2 comments

Here's a WIP of my proposal to fix #19. I still need to add more tests and fix the failing ones. In the interest of gathering feedback early I'm submitting the PR now.

I split the change into three commits and it might be helpful to review them one by one.

stasm avatar Sep 20 '17 23:09 stasm

I'll give this a closer look in the morning but at first glance this looks good. An example using combineReducers would be nice but certainly not necessary in this PR.

Thanks. I'll add an example and tests for combineReducers tonight or tomorrow. I also need to change the tests for connect. The ones I added in the first commit of this PR fail because the second commit changed the expected signature of connected components.

stasm avatar Sep 21 '17 07:09 stasm

I also need to change the tests for connect. The ones I added in the first commit of this PR fail because the second commit changed the expected signature of connected components.

Once this is fixed 👍

bcruddy avatar Sep 21 '17 12:09 bcruddy