Stanisław Małolepszy

Results 237 comments of Stanisław Małolepszy

> I also did not know that you can actually nest selectors. Variant values (which follow variant keys, e.g. `[other]`) are just like values of messages and attributes. They can...

Falling back to the calling message's scope might lead to unexpected naming conflicts when a term with a `$foo` parameter is used in a new message which also expects a...

> Is that sufficient reason to settle the answer to this issue's question as "no" then? I think so, yes! I'm leaving this open until I have a few tests...

Thanks. This looks like two issues: 1. The wording in the Guide is misleading. You give valid reasons for why it is so. 2. The `fluent.js` implementation doesn't currently look...

Sounds reasonable, thanks. Given our EBNF: ``` InlineExpression ::= StringLiteral | NumberLiteral | FunctionReference | MessageReference | TermReference | VariableReference | inline_placeable ``` it would appear that we need to...

Grammatical cases are already well-supported by Fluent; see http://projectfluent.org/fluent/guide/variants.html. But you're right—these two features will synergize well :)

Thanks, @Pike. A few more examples which illustrate why it's useful to resolve the references on the localization side rather than in the code (and pass translated strings as arguments)....

From https://bugzilla.mozilla.org/show_bug.cgi?id=1451450#c6: We'll need to support `VariantExpressions` and `AttributeExpression`s on both `MessageReferences` and `ExternalArguments`: -term[varname] $object[varname] -term.attr $object.attr Which I think is best solved by adding another level of nesting...

Some more explanation would help :) Do you mean something like the following? ```properties applications-action-always-ask = .label = Always ask applications-action-generic-label = {$menuitem.label} ``` And then in JS: ```js setAttributes(...

> Another potential case - https://phabricator.services.mozilla.com/D80944 The solution this patch settled on is also what I think is the best localization practice for a small number of variants: ```properties autocomplete-import-logins-from-chrome...