stash icon indicating copy to clipboard operation
stash copied to clipboard

Feature Request: add Offline Backups in Beta1 API

Open rofra opened this issue 5 years ago • 3 comments

In issue #1061, I figured out that in version 0.9.0_rc6, there is a dedicated page on https://stash.run/docs/v0.9.0-rc.6/guides/v1alpha1/offline_backup/ using the "Restic" Object only available in alpha1 and that will be deprecated soon.

I am in a case where I have a custom database (not Postgres, nor Mysql, not managed by your objects) where the Dababase files are stored in one and one directory only. When a process uses this directory, it creates on lock on it and no other can use it (neither read or write or delete, nothing).

When using the sidecar with BackupConfiguration, my database constantly changes and the backups takes a long time. The time it has ended, the S3 backup is always corrupted because of files have changed the time of the backup. So I cannot use a sidecar like BackupConfiguration.

Can you please port the "Offline Backup" solution, currently in Restic alpha1, to the beta1 ?

rofra avatar Mar 04 '20 11:03 rofra

I second this feature request because non-volumesnapshot-based, offline filesystem backups are obviously still needed.

Implementing my hybrid volumesnapshot / restic feature request ( #1099 ) could somehow alleviate the need for this kind of backup but not completely, since that depends on the CSI driver having VolumeSnapshotting capability which is often missing (like Hetzner Cloud Volumes in my case).

I am not sure why this important feature was not ported from 0.8.

I don't see how Stash could do without proper offline backups since VolumeSnapshotting is not always available (and limited in its current form anyways) and online backups are just complete non-starters for many workloads.

asoltesz avatar May 12 '20 20:05 asoltesz

Any news regarding the request ? Nearly 3 months away

rofra avatar May 31 '20 12:05 rofra

Our team is currently busy with more higher priority tasks. Considering our current pipeline, I don't think we will be able to ship this feature in 0.9.x release as well as probably 0.10.x release. We will love to see a PR from the community.

Meanwhile, Stash provides Hooks for both backup and restore. You can use the hooks to shutdown your application prior to backup and resume after backup. An example of hooks for MySQL database is shown here, https://stash.run/docs/v0.9.0-rc.6/guides/latest/hooks/backup-and-restore-hooks/

hossainemruz avatar May 31 '20 12:05 hossainemruz