stash icon indicating copy to clipboard operation
stash copied to clipboard

Do I need to delete the init containers after recovery?

Open LeoQuote opened this issue 5 years ago • 3 comments

First thanks for your product so I can easily recovery from a recent mistaken action.

I recoveried with RestoreSession , it did very well.

But I noticed there is an additional init container in the deployment , do I have to clean it manually ? or stash will clean it for me ?

If I dont clean it , will it redo the recovery when I restart the pod?

LeoQuote avatar Jan 16 '20 11:01 LeoQuote

@LeoQuote We are glad to know that it helped you to recover.

But I noticed there is an additional init container in the deployment , do I have to clean it manually ? or stash will clean it for me ?

If you delete the RestoreSession, Stash will remove the init-container automatically. Beware that it will cause your workload to restart.

If I dont clean it , will it redo the recovery when I restart the pod?

No. The init-container will not restore if a restore has been done already for respective RestoreSession.

hossainemruz avatar Jan 16 '20 11:01 hossainemruz

Thanks for your quick reply! It would be awesome If we can add these knowledge at the end of recovery document. Maybe I can add a pr for it?

  • https://github.com/stashed/docs/blob/master/docs/guides/latest/workloads/deployment.md#cleaning-up
  • https://github.com/stashed/docs/blob/master/docs/guides/latest/workloads/daemonset.md#cleaning-up
  • https://github.com/stashed/docs/blob/master/docs/guides/latest/workloads/statefulset.md#cleaning-up

LeoQuote avatar Jan 16 '20 16:01 LeoQuote

That will be great. Btw, we have already mentioned that in overview doc but I think it will be helpful to repeat this information in the docs you have pointed out.

Ref: https://stash.run/docs/v0.9.0-rc.2/guides/latest/workloads/overview/#how-restore-process-works

hossainemruz avatar Jan 16 '20 17:01 hossainemruz