stash icon indicating copy to clipboard operation
stash copied to clipboard

[RFC] Improving the merge modal window layout

Open echo6ix opened this issue 1 year ago • 0 comments
trafficstars

Summary

To propose a cosmetic adjustment to the merge modal window to ensure consistency in the placement of the "source" and "destination" fields and the addition of helper text for clarity of what scene is the merge target.

Problem

The current layout is fundamentally good. The first Merge modal window presents a Source field first (top) and a Destination field second (bottom). After progressing from this modal, the second modal window presents the Destination fields first (left column) and the Source fields second (right column).

This inconsistency in placement between the first and second modal has added confusion when merging for me, and at least one other user (@DogmaDragon), see Discord). I strongly suspect if two advanced contributors often find this confusing, it isn't unlikely that other users may get confused.

Additionally, there is a lack of helper text to guide users on the role of each field.

Proposed Solution

The following cosmetic adjustments:

  1. Consistent Placement of the Fields. Ensure the Source and Destination fields follow the same order on both modal windows. Whether the placement is top to bottom, or left to right, the Source fields should be first, and the Destination fields should be second on both modals. The specific proposed adjustment would be to flip the Source and Destination columns on the second Merge modal window, where Source would be the first column, and Destination the second column.
  2. Helper Text. Add helper text on the first modal window, below the corresponding Source and Destination fields.
    • Source helper text: Scene to merge
    • Destination helper text: Target scene where source will be merged into

image

echo6ix avatar Oct 02 '24 03:10 echo6ix