stash icon indicating copy to clipboard operation
stash copied to clipboard

[Bug Report] Libary type exclusions propogate to nested subdirectories

Open feederbox826 opened this issue 1 year ago • 2 comments

Describe the bug Library path exclusions propogate to subdirectories and don't act as intended

To Reproduce Steps to reproduce the behavior:

  1. Create library at /media/stash/images for images
  2. Create library at /media/stash for videos
  3. Add libraries to stash with only videos/images enabled for each directory
  4. Content of subdirectories are excluded as they are in the parent directory
  5. excluded content in the subdirectory is included as part of the parent directory

The video/images selection of parent directories is propogated to and overrides subdirectories, preventing subdirectory exclusion/ specific inclusion

Expected behavior Subdirectories would be handled independently regardless of file structure

Screenshots settings/ expected:

path images video
/media
/media/videos
/media/images

actual:

path images video
/media
/media/videos ❌ (inherit)
/media/images ❌ (inherit)

Stash Version: (from Settings -> About): v0.26.1

Desktop (please complete the following information): N/A

Smartphone (please complete the following information): N/A

Additional context https://discord.com/channels/559159668438728723/559159910550732809/1249850025509392496

feederbox826 avatar Jun 11 '24 01:06 feederbox826

I was just running into an issue with this as well. I think the issue is that the order of the Libraries really matters...

I was having an issue where I couldn't get photos to add.
1st Library was /Volumes/Main_Drive/Diamond/Clean Videos: ✅ Photos: ❌ 2nd Library was /Volumes/Main_Drive/Diamond/Clean/_Photos Videos: ❌ Photos: ✅

In this order NO photos in the _Photos directory was added, but any videos in that directory were added.

Now, if I flip the order of the libraries so that they are 1st Library was /Volumes/Main_Drive/Diamond/Clean/_Photos Videos: ❌ Photos: ✅ 2nd Library was /Volumes/Main_Drive/Diamond/Clean Videos: ✅ Photos: ❌

Now, this adds all of the photos and it doesn't added the video in the _photos directory.

On a side note to this issue, I would love the ability to reorder the libraries in the interface short of deleting and re-adding them which is what you have to do now. From my testing, if you don't rerun the Scan in between, it doesn't seem to muck the DB. But god that is scary every time!

kashmir772 avatar Aug 16 '24 04:08 kashmir772

Reproduced on https://github.com/stashapp/stash/commit/76648fee66bce1356dbce2de5871205f68f6f3f0.

DogmaDragon avatar Nov 22 '24 21:11 DogmaDragon