stash

stash copied to clipboard

Reame
Issues

Tag Favoriting

Open Dankonite opened this issue 1 year ago • 7 comments

added tag favoriting, still needs the filter support

Mar 26 '24 10:03 Dankonite

Added the filter getting a wierd error tho and no idea what causes this. Not ready yet

Mar 26 '24 11:03 Dankonite

Finally got the filter to work

Mar 26 '24 12:03 Dankonite

Thanks for the PR. Please address the failed checks.

Mar 26 '24 23:03 WithoutPants

sorry, new to linters and such, no idea if that was the only problem or if I need to clean up something else also. I will google a proper linting tutorial if more stuff comes back messy

Mar 27 '24 04:03 Dankonite

sorry, new to linters and such, no idea if that was the only problem or if I need to clean up something else also. I will google a proper linting tutorial if more stuff comes back messy

Just look through your changes and undo the pointless ones, like changing indentation. That would be a start. For the others, go to checks and look at the details for why they're failing.

Mar 27 '24 15:03 SpedNSFW

so I ran yarn validate and some of the stuff that is throwing errors are things I didnt even mess with lmao Do I need to make these changes from a diferent branch or something. I just forked off of develop maybe at a bad time or something

Mar 28 '24 03:03 Dankonite

Migration version conflicts with existing one https://github.com/stashapp/stash/blob/develop/pkg/sqlite/migrations/56_studio_favorite.up.sql.

You will need to either update the existing migration or bump the version.

Apr 26 '24 21:04 DogmaDragon