stash icon indicating copy to clipboard operation
stash copied to clipboard

Update dependencies

Open DingDongSoLong4 opened this issue 2 years ago • 0 comments

After not understanding why #3093 was refusing to work in a release build, I decided to just go ahead and try updating all the dependencies - which indeed ended up fixing the problem. I'll update #3093 after this is merged.

This updates all the UI dependencies to the latest versions, with the exceptions being leaving react at v17, react-router at v5 and bootstrap at v4. I have managed to do the react 18 and react-router v6 migration, but that involves a bit more editing so I'll leave that off here. I also attempted to migrate to bootstrap v5 but so many things broke and I very quickly gave up.

The one issue is that the formatjs v3 -> v4 migration has broken the formatting for the setup.welcome.config_path_logic_explained intl string as HTML/XML characters now need to be escaped with an apostrophe. The fix is fairly straightforward to apply to all languages, but I'm not sure how I should be going about doing it (I'm assuming I can't just edit the source files).

Besides that, the only other visible change that I could find is that most of the icons have been tweaked, from the update to fontawesome - but these differences are very minor.

And then I've also replaced react-slick with @ant-design/react-slick which looks to be better maintained, and removed query-string in favour of the native URLSearchParams. The latter does make the query filter code a bit more verbose, but we get to drop the dependency and theoretically achieve (very slightly) better performance.

DingDongSoLong4 avatar Nov 13 '22 12:11 DingDongSoLong4