stash icon indicating copy to clipboard operation
stash copied to clipboard

feat: UI - Performer scraper result list with image and basic data

Open TgSeed opened this issue 2 years ago • 5 comments

As the title says, but also added toast and error messages.

closes #2695

TgSeed avatar Jun 25 '22 20:06 TgSeed

Stashbox functionality for this part (Performer scraper) might have got disabled/non-functional. I have no idea how that works and don't have stash box access to test and try to make it functional.

Can anyone please contribute or help with this? Thanks.

TgSeed avatar Jun 25 '22 21:06 TgSeed

There are also some minor contributions to #571 in this pull request.

TgSeed avatar Jun 26 '22 10:06 TgSeed

post-scraping items in cache.ScrapeName is not done for scenes, and it might need to be done there too or neither.

It solves my issue where I use stash on my phone via my computer local network IP, but my phone has no internet access/cannot access the images' origin url while my computer can and is connected to the internet. Post scraping converts the images' origin url to base64, so the image will be displayed on my phone too, even without internet access.

It may also solve some security concerns about connecting to the image's origin url.

TgSeed avatar Jun 27 '22 09:06 TgSeed

80d138a has resolved the merge conflicts that has been recently occurred.

TgSeed avatar Sep 25 '22 20:09 TgSeed

If this works, big up to you, this feature is much needed !

ghost avatar Oct 22 '22 22:10 ghost

Hey, don't wanna step on any toes, but since I can't collaborate on this PR directly, I made a variant (that keeps ownership for @TgSeed) but updates for the breaking changes in the codebase. If you want to pick the changes back, I can close mine. #3499

StashPRs avatar Mar 01 '23 07:03 StashPRs

Closing in favour of #3499, please see my comments there.

WithoutPants avatar Mar 07 '23 05:03 WithoutPants

@StashPRs I am glad that you did it, hope that gets merged anyway. Thanks

TgSeed avatar Mar 09 '23 20:03 TgSeed