stash-box icon indicating copy to clipboard operation
stash-box copied to clipboard

[Bug Report] Commas in Aliases split the alias on call to ScrapeSinglePerformer

Open BonerFide opened this issue 1 year ago • 0 comments

Describe the bug Commas are accepted when adding an alias, however when being scraped via Stash (eg ScrapeSinglePerformer) they're not escaped or quoted etc in the return list of aliases, so it will then split an alias with a comma into 2 aliases. This becomes a problem for stash when the comma is what's keeping the aliases distinct.

To Reproduce Steps to reproduce the behavior:

  1. Add an alias with a comma when creating or modifying a performer
  2. Scrape the performer using scrapeSinglePerformer

{ "data": { "scrapeSinglePerformer": [ { ... "aliases": "abc, abc, def", ... "__typename": "ScrapedPerformer" } ] } }

Expected behavior Ideally these would be escaped and thus valid everywhere, but it may be simply easier for now to disallow commas in aliases or split them on a comma at the stash-box point of entry.

{ "data": { "scrapeSinglePerformer": [ { ... "aliases": ["abc,abc", "def"], ... "__typename": "ScrapedPerformer" } ] } }

image

BonerFide avatar Mar 21 '24 00:03 BonerFide