stash-box icon indicating copy to clipboard operation
stash-box copied to clipboard

Add fingerprint input on scene creation in webui

Open ikmckenz opened this issue 1 year ago • 3 comments

Mostly based this off the urlInput file. Tested working locally.

Resolves #476, which I guess was originally about adding some new hash type but has been edited to just "add fingerprints manually", which is what this does.

ikmckenz avatar Feb 03 '24 02:02 ikmckenz

Rebased, and fixed formatting (yarn validate now passes)

ikmckenz avatar Feb 19 '24 02:02 ikmckenz

I strongly disagree with this being the default feature. While I can see a possible use case for this, without some safeguards it opens up a huge vector for abuse.

While Stash requirement is not ideal, it automatically adds certain safeguards like:

  • Hash being generated on actual file
  • File duration being sent along with the hash
  • Using the same algorithm as everyone else

DogmaDragon avatar Feb 24 '24 16:02 DogmaDragon

Perhaps the entire “create scene” button in the webui should be configurable via a feature flag in that case? Operators who only want scenes via stash should disable entirely, and those operators who want it enabled will have users who can submit scenes with hashes in the webui.

ikmckenz avatar Mar 05 '24 08:03 ikmckenz