stash-box icon indicating copy to clipboard operation
stash-box copied to clipboard

[Feature] Add validation for name field against aliases

Open DogmaDragon opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. Right now, stash-box allows adding an identical alias as the name. Since search and scraping already matches both, I feel like this is redundant clutter.

Describe the solution you'd like Add validation for name field against aliases in the frontend.

Additional context image

DogmaDragon avatar Oct 27 '23 05:10 DogmaDragon

Also worth noting that Stash already prevents identical aliases. I've seen others mention this causing errors when trying to scrape from a Stash-Box into Stash, but I haven't run into it personally yet.

AdultSun avatar Oct 27 '23 05:10 AdultSun

True, but only if they have the same capitalization. That's a different issue, https://github.com/stashapp/stash/issues/4250.

DogmaDragon avatar Oct 27 '23 05:10 DogmaDragon

I had a different take on resolving this issue earlier this year https://github.com/stashapp/stash-box/issues/610

TLDR:

  • Consolidate the name and alias fields into one Names field
  • Present the names using filter chips styling
    • Filter chips look exactly the same as the incumbent chips, but they add a trailing drop down caret icon
    • This gives each chip the option to Set as primary name and Delete name
    • A name set as primary gets a unique chip presentation to stand out
      • Either a different colored chip
      • Or a chip with a leading icon, such as a star

image

This solves several issues with manual data entry such as the need for validation against duplicate aliases, and forgetting to re-add a primary name as an alias if the submitter is flipping primary names.

Alternate implementation

Thought of alternate implementation of the above without using a filter chip

image

echo6ix avatar Oct 27 '23 17:10 echo6ix