CommunityScrapers icon indicating copy to clipboard operation
CommunityScrapers copied to clipboard

Migrate movieByURL to groupByURL

Open nrg101 opened this issue 7 months ago • 4 comments

Scraper type(s)

  • [x] groupByURL

Examples to test

  • https://www.transsensual.com/movie/10709531/ts-chronicles
  • https://www.evilangel.com/en/movie/Transtoinette/129088

Short description

Now that https://github.com/stashapp/stash/issues/5793 is complete, I think that this migration can now be done? I guess it needs a new build of Stashapp to be able to be tested, as I get an out-of-range error if I attempt to use one of the scrapers with groupByURL:

2025-05-30 16:06:00
Error   
scrapeGroupURL: input: scrapeGroupURL Internal system error. Error <runtime error: index out of range [0] with length 0>
2025-05-30 16:06:00
Error   
runtime error: index out of range [0] with length 0
2025-05-30 16:05:54
Debug   
Reading scraper configs from /root/.stash/scrapers

If it works, this fixes #2229

nrg101 avatar May 30 '25 15:05 nrg101

ah i missed some scraper changes... will have a look now

nrg101 avatar May 30 '25 15:05 nrg101

https://github.com/stashapp/stash/issues/5793 was merged into develop, but it will only be released in v0.29.0 build, so this PR should be delayed until then.

DogmaDragon avatar May 30 '25 18:05 DogmaDragon

Will also be a major breaking change, might be worth leaving a branch on moviesbyurl

feederbox826 avatar May 30 '25 22:05 feederbox826

Mentioned in Discourse https://discourse.stashapp.cc/t/communityscrapers-master-branch-breaking-change/2058

feederbox826 avatar Jun 11 '25 16:06 feederbox826

We're at 0.29.0! I think a week should be good enough, and is in line with the notice for CommunityScrapers. I'll come back for a branch and merge on 2025-10-27

feederbox826 avatar Oct 21 '25 03:10 feederbox826

It's the 27th! will have a look through conflicts and will resolve manually

feederbox826 avatar Oct 27 '25 22:10 feederbox826

Forsaking validator, will solve manually

feederbox826 avatar Oct 28 '25 01:10 feederbox826