Stanislav Zhuk
Stanislav Zhuk
We still need `$DOCKER_HOST`, because the endpoint is selected from the `default` context in `docker.com/docker/docker/client`, and `docker context use` doesn't work by itself. The only way to get rid of...
> And really `$DOCKER_HOST` should only matter when we're using the docker client, and most of the time we shouldn't need it there? Or does the docker/docker API use `$DOCKER_HOST`?...
I'm going to look into this after I'm done with my other priorities.
I'm going to close this PR in favor of #5855, because I think we can use this announcement bar in the stable branch for another purpose, like the announcement bar...
I tested it, but still can't figure it out, so I decided to fix this first: - #5862
Note: Looking into https://docs.docker.com/engine/api/sdk/examples/ I noticed that I didn't close the connection to the client in `GetDockerClient()`: ``` defer client.Close() ``` Tested this change on **tb-macos-arm64-7** - the same result...
I see a difference in the syntax of Docker API requests in: https://github.com/ddev/ddev/blob/08d94f74f25c5617791a71f2be15e403cf79510f/pkg/ddevapp/ddevapp.go#L183-L191 Old `fsouza/go-dockerclient`: `http://unix.sock/containers/json?all=1&filters=%7B%22label%22%3A%5B%22com.docker.compose.service%3Dweb%22%2C%22com.ddev.site-name%3Dd10%22%5D%7D` `filters={"label":["com.docker.compose.service=web","com.ddev.site-name=d10"]}` `curl --unix-socket /Users/testbot/.colima/default/docker.sock "http://localhost/v1.24/containers/json?all=1&filters=%7B%22label%22%3A%5B%22com.docker.compose.service%3Dweb%22%2C%22com.ddev.site-name%3Dd10%22%5D%7D"` New `docker/docker/client`: `http://%2Fvar%2Frun%2Fdocker.sock/v1.44/containers/json?all=1&filters=%7B%22label%22%3A%7B%22com.ddev.site-name%3Dd10%22%3Atrue%2C%22com.docker.compose.service%3Dweb%22%3Atrue%7D%7D` `filters={"label":{"com.ddev.site-name=d10":true,"com.docker.compose.service=web":true}}` `curl --unix-socket /Users/testbot/.colima/default/docker.sock "http://localhost/v1.24/containers/json?all=1&filters=%7B%22label%22%3A%7B%22com.ddev.site-name%3Dd10%22%3Atrue%2C%22com.docker.compose.service%3Dweb%22%3Atrue%7D%7D"`
Rebased to resolve conflicts.
Hi @allanlaal, It's a good idea, reopened it. It reminds me how PhpStorm uses `composer.json` to determine what PHP features are available or not. > I only want ddev to...
I will show how it works with simple docker images that have a `test` label: ``` $ docker images --filter=label=test REPOSITORY TAG IMAGE ID CREATED SIZE ``` Build an image...