Stas Bekman

Results 664 comments of Stas Bekman

Thank you for confirming it solved your problem, William!

Not sure why you've tagged me, Jack ;) I have just reported the problem on behalf of my colleague.

@lhoestq, is it possible to make a new release now that this issue has been fixed? Thank you!

Thank you very much, Quentin!

> But I was not sure when I should check if new nn.Modules are added. Users do not add a nested zero.Init() for the dynamically defined class. oh, but they...

I think we have an unrelated problem which probably requires a separate issue. And that's when a user wants to work with 2 independent models. I have no idea how...

> Is my understanding correct? It is this: ``` dynamically import main class A with zero.Init(): a = Instantiate class A dynamically import class B1 via a.config.b1_name with zero.Init(): a.b1...

Sounds good, @tohtana - I'm just not sure I follow your last comment as it contradicts the first comment. The first and the last are the same, no? And if...

@tohtana, they aren't substitutes, they are the first time definition. A substitute would indeed be a huge issue (which in fact we need to talk about at some point too,...

Thank you for clarifying, @tjruwase. We already know these patterns aren't supported, hence this Issue. All I was trying to communicate is that it's up to you what you consider...