Stas

Results 71 comments of Stas

Thanks @NeilSlater-Clixifix Though I'm still unsure how `jsonapi.rb` is the issue here? Again, this is a library you can use to build/shape the API, the goal is not to provide...

> I am using the error renderers by handling exceptions in the base controller and calling `render jsonapi_errors:` there. So the error payloads are all json-api compliant from the example,...

I'll have to make it backwards compatible, but definitely could have it released by next week. Ty ty for bringing it all up!

@mamhoff `jsonapi_paginate()` works on plain ruby arrays: https://github.com/stas/jsonapi.rb/blob/master/spec/dummy.rb#L97 Have you considered doing the decoration before the array is passed to the method? Eg.: ```diff class UserDecorator < SimpleDelegator def fantastic_for_rendering...

> Yes - the problem is that the decoration materializes the ActiveRecord scope before pagination, and we instantiate and decorate way more objects than we need, leading to a pretty...

The proposed changes are removing fixes for known and performance issues, like unscoping an ActiveRecord collection. It also moves the caching of the `total` from the passed object, into the...

Could not reproduce this with latest version from PPA. Can be closed, please reopen if it doesn't work.

Oh, yup it does, even though it sounds quite specific. Generally I don't think this should affect end-users too much, otherwise this issue would have been brought up already :joy:...

Hmm, @MisterKeefe it would be amazing if you could provide an example how to reproduce this. It never happened to me. Thank you!

Sorry for the late response @jb098 I don't have to report any other potential issues. Thanks for reviewing this!