luautf8 icon indicating copy to clipboard operation
luautf8 copied to clipboard

add ispunct function to check if a word is a punctuation

Open chenghf opened this issue 1 year ago • 3 comments

chenghf avatar Oct 24 '24 07:10 chenghf

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Oct 24 '24 07:10 sonarqubecloud[bot]

I'm not very approve with this API, you should just use "%p" to match a Unicode punctuation. If you add this one, all Unicode categories should all have their own API. That makes this library messy.

starwing avatar Oct 24 '24 20:10 starwing

Thank you. I see.


发件人: Xavier Wang @.> 发送时间: 2024年10月25日 4:37 收件人: starwing/luautf8 @.> 抄送: chenghf @.>; Author @.> 主题: Re: [starwing/luautf8] add ispunct function to check if a word is a punctuation (PR #54)

I'm not very familiar with this API, you should just use "%p" to match a Unicode punctuation. If you add this one, all Unicode categories should all have their own API. That makes this library messy.

― Reply to this email directly, view it on GitHubhttps://github.com/starwing/luautf8/pull/54#issuecomment-2436294404, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAO4N46OWVTKAWERPEMG3LZ5FLA7AVCNFSM6AAAAABQQNT4COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZWGI4TINBQGQ. You are receiving this because you authored the thread.Message ID: @.***>

chenghf avatar Oct 25 '24 02:10 chenghf