lbuffer icon indicating copy to clipboard operation
lbuffer copied to clipboard

Does it work with Lua 5.4?

Open ghost opened this issue 2 years ago • 0 comments

Hi! Your code looks quite useful and nice, but it gives funny warnings when compiled with Lua 5.4:

lbuffer.c: In function ‘write_int32’:
lbuffer.c:261:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
  261 |             case 4: *s++ = (n >> 24) & 0xFF;
      |                     ~~~~~^~~~~~~~~~~~~~~~~~

(and similar repeat over again). Are fallthroughs intended?

Also, it requires LUA_QS and LUA_QL, absent in 5.4. I've copied them from Lua 5.2 and it kinda works, but I ask in case an update or some reworking is needed. Thank you in advance.

ghost avatar Apr 07 '22 05:04 ghost