starship icon indicating copy to clipboard operation
starship copied to clipboard

Published 20 hours ago • verified publisher icon starship

feat: add gradle module

Open NyCodeGHG opened this issue 2 years ago • 3 comments

I added a module to display the version of Gradle.

Description

I added 2 different strategies which are available via the config, because invoking the gradle executable is really slow. Because almost every gradle project uses the Gradle Wrapper i made it the default option to parse the gradle version from the wrappers config file.

Motivation and Context

It adds support for Gradle, a popular choice for the build system in the Java and Kotlin Ecosystem.

Screenshots (if appropriate):

image

How Has This Been Tested?

  • [ ] I have tested using MacOS
  • [x] I have tested using Linux
  • [x] I have tested using Windows

I tested my changes on Windows and on a GitHub codespace, I don't own a device running macOS so I can't test that sadly.

Checklist:

  • [x] I have updated the documentation accordingly.
  • [x] I have updated the tests accordingly.

NyCodeGHG avatar Sep 30 '22 12:09 NyCodeGHG

Please also update the presets in docs/.vuepress/public/presets/toml.

davidkna avatar Oct 14 '22 11:10 davidkna

Now that I think about it, I think it would be better to drop the whole (./)gradle(w) --version execution thing and only provide the wrapper strategy, because the execution is so slow that it would time out most of the time and most gradle users use the wrapper anyway.

NyCodeGHG avatar Oct 21 '22 14:10 NyCodeGHG

Now that I think about it, I think it would be better to drop the whole (./)gradle(w) --version execution thing and only provide the wrapper strategy, because the execution is so slow that it would time out most of the time and most gradle users use the wrapper anyway.

That sounds good.

davidkna avatar Oct 23 '22 16:10 davidkna

Hi! I finally found time and motivation to apply the requested changes and merge the conflicts. I'm sorry that it took some time

NyCodeGHG avatar Dec 07 '22 11:12 NyCodeGHG

I'm confused, when i generate the schema locally, there are no changes.

NyCodeGHG avatar Dec 07 '22 11:12 NyCodeGHG

@NyCodeGHG Looks like a text encoding issue, I will go ahead and update it.

davidkna avatar Dec 07 '22 11:12 davidkna

oh sorry, i didn't see your message, yes it was a encoding issue caused by powershell

NyCodeGHG avatar Dec 07 '22 11:12 NyCodeGHG

Thank you for your contribution @NyCodeGHG and thank you for reviewing @davidkna.

andytom avatar Dec 17 '22 12:12 andytom