cairo icon indicating copy to clipboard operation
cairo copied to clipboard

Insert right paren after cursor when completing funciton/method calls

Open RuneRogue opened this issue 1 year ago • 6 comments

I have first check whethere function have parameters or not . If it have parameter then it will place curser after the '()' . If function have parameters then the it will place curser between the parenthesis like this '(l)' . Also i have added space between paranthesis so curser appears properly .

Fixed #5935


This change is Reviewable

RuneRogue avatar Aug 31 '24 07:08 RuneRogue

@orizi I have made changes as you have suggested.

RuneRogue avatar Sep 01 '24 06:09 RuneRogue

@orizi sorry I am not getting what you are suggesting. It's exactly like what you have suggested.

RuneRogue avatar Sep 01 '24 06:09 RuneRogue

@orizi I have added test for completion of method . Also I have added full signature method.

RuneRogue avatar Sep 01 '24 08:09 RuneRogue

@orizi is that good? Also I am not good at testing .Honestly I took help from AI . So It'll be great if you do testing from your side. By the way code is running perfectly.

RuneRogue avatar Sep 01 '24 08:09 RuneRogue

@orizi I have removed full signature that displaying parameter . You are right It's going to be annoying

RuneRogue avatar Sep 01 '24 08:09 RuneRogue

@orizi reach me out if any changes you want to do.

RuneRogue avatar Sep 01 '24 09:09 RuneRogue

Done in #6380

Draggu avatar Sep 19 '24 14:09 Draggu