cairo-lang icon indicating copy to clipboard operation
cairo-lang copied to clipboard

Support for python 3.9 & 3.10

Open Amxx opened this issue 2 years ago • 6 comments

Fixes #41


This change is Reviewable

Amxx avatar Mar 29 '22 15:03 Amxx

@liorgold2 is it possible to merge this small change? gives opportunity for toolchains to use latest Python releases

0xLaplace avatar Apr 29 '22 09:04 0xLaplace

Is the extend instead of += also required for python3.9/3.10? Why?

I prefer extend(), but I don't think it matters. Reasons for my preference:

  • More readable
  • Faster (https://gist.github.com/mekarpeles/3408081)
  • You can chain expressions
  • Consistency (have to pick one and try to be consistent, thus pick extend for first several reasons)

It really does not matter though in this context.

antazoey avatar May 03 '22 15:05 antazoey

Hey - can this please get merged soon? Really hoping to use the newer python versions without having this issue: https://github.com/starkware-libs/cairo-lang/issues/41

wandcrafting avatar May 21 '22 01:05 wandcrafting

Hey - can this please get merged soon? Really hoping to use the newer python versions without having this issue: #41

Please see my comment above.

liorgold2 avatar May 21 '22 10:05 liorgold2

Hey - can this please get merged soon? Really hoping to use the newer python versions without having this issue: #41

Please see my comment above.

There is still incompatibility with frozendict standing in the way of supporting 3.10.x: https://github.com/Shard-Labs/starknet-devnet/pull/108

0xLaplace avatar May 26 '22 08:05 0xLaplace

Please see my previous comment.

On Sat, May 21, 2022, 04:08 Dhrumil Shah @.***> wrote:

Hey - can this please get merged soon? Really hoping to use the newer python versions without having this issue: #41 https://github.com/starkware-libs/cairo-lang/issues/41

— Reply to this email directly, view it on GitHub https://github.com/starkware-libs/cairo-lang/pull/43#issuecomment-1133490247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJDO2JIE4A7NN4ODKKFNG3DVLAZSNANCNFSM5R6YSCYQ . You are receiving this because you were mentioned.Message ID: @.***>

liorgold2 avatar Oct 11 '22 07:10 liorgold2