starknet.js icon indicating copy to clipboard operation
starknet.js copied to clipboard

Test: EstimateFee Bulk with Cario1 Acc

Open RolandoDrRobot opened this issue 2 years ago • 1 comments

Motivation and Resolution

This ia solution for this issue: https://github.com/starknet-io/starknet.js/issues/904

RPC version (if applicable): v6

Checklist:

  • [x] Performed a self-review of the code
  • [x] Rebased to the last commit of the target branch (or merged it into my branch)
  • [x] Linked the issues which this PR resolves
  • [x] Documented the changes in code (API docs will be generated automatically)
  • [x] Updated the tests
  • [x] All tests are passing

Test

Captura de pantalla 2024-02-17 a la(s) 17 06 02

RolandoDrRobot avatar Feb 17 '24 23:02 RolandoDrRobot

@ivpavici @tabaktoni could you code review this one pls? thank you

RolandoDrRobot avatar Feb 17 '24 23:02 RolandoDrRobot

Hey guys! coming back to this. gonna check today, thanks

RolandoDrRobot avatar Mar 25 '24 19:03 RolandoDrRobot

@tabaktoni @ivpavici could you guys re review? the pic of the description (tests) is updated with latest changes, thank you!

RolandoDrRobot avatar Mar 28 '24 14:03 RolandoDrRobot

Since devnet is now using Cairo 1 accounts by default and the ecosystem has moved from Cairo 0 this issue/pr is not needed any more...

Thanks @RolandoDrRobot for your effort, I will send you a small reward!

ivpavici avatar Apr 04 '24 09:04 ivpavici

@ivpavici thank you! best regards 🙏

RolandoDrRobot avatar Apr 08 '24 04:04 RolandoDrRobot