starknet-docs icon indicating copy to clipboard operation
starknet-docs copied to clipboard

Published 20 hours ago • verified publisher icon starknet-io

feat: add `l1_handler_transaction` version table

Open glihm opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. Currently, we have a table for transaction version, but l1_hander_transaction is not in this table. This is important to have in order to compute the transaction hash.

Describe the solution you'd like Add l1_handler_transaction version (which is 0 currently) to the transaction table in the page Transaction Types. Or a new table in the L1-L2 Messaging page where the computation of l1_handler_transaction actually is.

I would be happy to open a PR if this suggestion is approved.

glihm avatar Nov 27 '23 00:11 glihm

@glihm Please feel free to open a PR and assign me as the reviewer.

stoobie avatar Jan 02 '24 09:01 stoobie

@glihm Are you still interested? This fell completely off my radar. I'm checking with the experts on their thoughts about this. Will get back to you. Feel free to ping me.

stoobie avatar Apr 03 '24 14:04 stoobie

@stoobie yeah that looks like a great idea. It would solve the issue of not having the actual version of l1_handler_transaction being mentioned anywhere in the doc

tdelabro avatar Apr 03 '24 18:04 tdelabro

@glihm Are you in our Telegram channel? Would love to touch base with you there: https://t.me/+9VC94EQA8dY4ZTZh

stoobie avatar May 23 '24 13:05 stoobie

@stoobie sorry for the delay and thanks again for pinging. PR open, please don't hesitate any feedback on the PR. 🫡

glihm avatar May 27 '24 21:05 glihm