starknet-docs icon indicating copy to clipboard operation
starknet-docs copied to clipboard

fix: update serialization-of-cairo-types.adoc to correctly serialize u256 inside a struct

Open Kelvyne opened this issue 1 year ago • 2 comments

Fix mistake in serialization of U256 inside of a struct U256 are serialized as [low_128, high_128] as per the same documentation.

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix. If the PR is related to an open issue please link to it.

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

  • [ ] Changes have been done against main branch, and PR does not conflict
  • [ ] PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

Kelvyne avatar Aug 28 '24 20:08 Kelvyne

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1341/ .

starknet-bot avatar Aug 28 '24 20:08 starknet-bot

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1341/ .

starknet-bot avatar Sep 08 '24 12:09 starknet-bot

Already fixed in #1339, but thanks anyway!

LandauRaz avatar Oct 28 '24 17:10 LandauRaz