starknet-io
SRC-21: add out-of-band fee-on-transfer token standard
Could someone assign a SNIP number?
Assigning the number 21 to this SNIP. Skipping number 20 to avoid confusion with ERC-20
Hey @moodysalem, can you add a sections "Rationale" and "Security considerations" (to keep syntax uniform among snips). IMO you can delete section "Implementation" and "History" for the time being.
I think it would help to add more context on how this standard interacts with the ERC-20 token standard, e.g. does this standard require that the token be an ERC-20 token? The inteface should lie in the token contract? Should there be events?
I also think that adding a use case would be helpful. It's not clear to me what problems this standard comes to solve (this isn't a blocker for merging, but adding context may make it a better snip IMO).
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!