starknet-cairo-101 icon indicating copy to clipboard operation
starknet-cairo-101 copied to clipboard

Published 20 hours ago • verified publisher icon starknet-edu

Imports and Nits

Open drspacemn opened this issue 2 years ago • 0 comments

Moving PR comments to this issue.

Suggest CamelCase interface names as follows cairo-lang.org and OZ naming conventions.

Remove unused imports. And import OZ utils from openzeppelin.token.erc20.library import ERC20

Can remove internal tempvar binding with return in the if block.

Nit: suggest removing _storage from variables annotated @storage_variable

drspacemn avatar Jul 08 '22 16:07 drspacemn